Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive addresses recovery fixed #1031

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Receive addresses recovery fixed #1031

merged 1 commit into from
Jun 25, 2021

Conversation

levonpetrosyan93
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 commented May 10, 2021 •
edited
Loading

After recovering from mnemoics, wallet scans all wallet transactions, recognizes used addresses and adds them into addressbook.
The new code works as follows.

  1. If it is first run go inside if
  2. It iterates on wallet transactions
  3. For each output is checked if it is your's
  4. if not -> skip, if yes go and extract the address form the output,
  5. add the address into addressbook

@lgtm-com
Copy link

lgtm-com bot commented May 10, 2021

This pull request introduces 2 alerts when merging 7eba1d1 into 677b54c - view on LGTM.com

new alerts:

  • 2 for Unused static function

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 22, 2021
@reubenyap reubenyap added the bug label Jun 24, 2021
@levonpetrosyan93 levonpetrosyan93 merged commit d5aa685 into master Jun 25, 2021
@levonpetrosyan93 levonpetrosyan93 deleted the receive_address_recovery branch June 25, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-bezrukov a-bezrukov a-bezrukov approved these changes

@psolstice psolstice psolstice approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@levonpetrosyan93 @psolstice @a-bezrukov @reubenyap